Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deno install in Rust #3806

Merged
merged 25 commits into from
Jan 30, 2020
Merged

feat: deno install in Rust #3806

merged 25 commits into from
Jan 30, 2020

Conversation

bartlomieju
Copy link
Member

No description provided.

cli/installer.rs Outdated Show resolved Hide resolved
cli/installer.rs Show resolved Hide resolved
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Remove std/installer ?

@bartlomieju bartlomieju changed the title [WIP] deno install in Rust feat: deno install in Rust Jan 30, 2020
std/installer/test.ts Outdated Show resolved Hide resolved
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work. Let's figure out the std/installer hanging situation soon.

@ry ry merged commit de5c099 into denoland:master Jan 30, 2020
@bartlomieju bartlomieju deleted the rust_installer branch February 1, 2020 13:58
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
//std/installer couldn't be removed due to bug, but it's now deprecated.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
//installer couldn't be removed due to bug, but it's now deprecated.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
//installer couldn't be removed due to bug, but it's now deprecated.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
//installer couldn't be removed due to bug, but it's now deprecated.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
//installer couldn't be removed due to bug, but it's now deprecated.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
//installer couldn't be removed due to bug, but it's now deprecated.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
//installer couldn't be removed due to bug, but it's now deprecated.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
//installer couldn't be removed due to bug, but it's now deprecated.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
//installer couldn't be removed due to bug, but it's now deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants