New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement os.exit #454

Merged
merged 1 commit into from Aug 4, 2018

Conversation

2 participants
@ry
Collaborator

ry commented Aug 3, 2018

No description provided.

@ry ry requested a review from piscisaureus Aug 3, 2018

@piscisaureus

Looks good but... not test? I'm not used to that :)

@ry

This comment has been minimized.

Show comment
Hide comment
@ry

ry Aug 4, 2018

Collaborator

Its a bit hard to do a unit test now - but this is exercised somewhere in the suite. I agree it should have a unit test - I’ll circle back but land this now.

Collaborator

ry commented Aug 4, 2018

Its a bit hard to do a unit test now - but this is exercised somewhere in the suite. I agree it should have a unit test - I’ll circle back but land this now.

@ry ry merged commit 60f6067 into master Aug 4, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ry ry deleted the 20180803_exit branch Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment