New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen declarations #479

Merged
merged 3 commits into from Aug 8, 2018

Conversation

3 participants
@ry
Collaborator

ry commented Aug 7, 2018

continuation of #455

@ry ry referenced this pull request Aug 7, 2018

Closed

Generate declarations #455

@ry ry requested a review from piscisaureus Aug 7, 2018

@piscisaureus

This comment has been minimized.

Show comment
Hide comment
@piscisaureus

piscisaureus Aug 7, 2018

Collaborator

Is window currently not the global object? Or is it?

Collaborator

piscisaureus commented on js/globals.ts in 5d91e4b Aug 7, 2018

Is window currently not the global object? Or is it?

This comment has been minimized.

Show comment
Hide comment
@ry

ry Aug 7, 2018

Collaborator

it is

Collaborator

ry replied Aug 7, 2018

it is

send(msg: ArrayBufferView): Uint8Array | null;
}
interface Window {

This comment has been minimized.

@piscisaureus

piscisaureus Aug 8, 2018

Collaborator

I wonder -- is 'window' currently not the same as the global object?

@piscisaureus

piscisaureus Aug 8, 2018

Collaborator

I wonder -- is 'window' currently not the same as the global object?

This comment has been minimized.

@ry

ry Aug 8, 2018

Collaborator

Hmm ... not sure. how is that should be expressed in declaration files?
Anyway - it’s orthogonal to this PR. Landing.

@ry

ry Aug 8, 2018

Collaborator

Hmm ... not sure. how is that should be expressed in declaration files?
Anyway - it’s orthogonal to this PR. Landing.

@ry ry merged commit 817380a into master Aug 8, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ry ry deleted the gen_declarations branch Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment