New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tweaks #487

Merged
merged 3 commits into from Aug 9, 2018

Conversation

2 participants
@piscisaureus
Collaborator

piscisaureus commented Aug 9, 2018

0c6aeb3 Remove the 'cfg' variable from rust templates.
514303c Remove 'rust_staticlib' build template
98e8b10 Fix test_cc build dependencies

@piscisaureus piscisaureus requested a review from ry Aug 9, 2018

piscisaureus added some commits Aug 9, 2018

Remove 'rust_staticlib' build template
It's not used for anything, nor are we planning to use it.
Remove the 'cfg' variable from rust templates
It's never been used for anything other than enabling crate features.
Use the 'features' variable instead, it's more readable and more terse.
@ry

ry approved these changes Aug 9, 2018

LGTM

@piscisaureus piscisaureus merged commit 69ee336 into denoland:master Aug 9, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@piscisaureus piscisaureus deleted the piscisaureus:build_tweaks branch Aug 9, 2018

hayd added a commit to hayd/deno that referenced this pull request Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment