New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard tests #496

Merged
merged 3 commits into from Aug 10, 2018

Conversation

2 participants
@kitsonk
Contributor

kitsonk commented Aug 9, 2018

Resolves #495

Currently fails on deno_ns because deno_ns does not properly rewrite error stacks at the moment (ergo a good reason for these tests 馃榿)

@ry

Looks good - I have a few comments

Show outdated Hide outdated tools/check_output_test.py Outdated
Show outdated Hide outdated tools/check_output_test.py Outdated
Show outdated Hide outdated tests/008_stack_trace.ts Outdated
@ry

This comment has been minimized.

Show comment
Hide comment
@ry

ry Aug 9, 2018

Collaborator

@qti3e we're porting your work to the new version - just thought you'd like to see : )

Collaborator

ry commented Aug 9, 2018

@qti3e we're porting your work to the new version - just thought you'd like to see : )

@kitsonk

This comment has been minimized.

Show comment
Hide comment
@kitsonk

kitsonk Aug 10, 2018

Contributor

@ry I made some assumptions about integrating the python unit tests, but it is all there. Still deno_ns fails because it is not properly rewriting the call stack.

Contributor

kitsonk commented Aug 10, 2018

@ry I made some assumptions about integrating the python unit tests, but it is all there. Still deno_ns fails because it is not properly rewriting the call stack.

@ry

Looks good - thanks for adding util_test! I'll look into the deno_ns situation tomorrow but in light of #494 if it's not easily doable I will just remove deno_ns.

Show outdated Hide outdated tools/util_test.py Outdated
Show outdated Hide outdated tools/util.py Outdated
Show outdated Hide outdated tools/test.py Outdated
@kitsonk

This comment has been minimized.

Show comment
Hide comment
@kitsonk

kitsonk Aug 10, 2018

Contributor

@ry feedback addressed and rebased

Contributor

kitsonk commented Aug 10, 2018

@ry feedback addressed and rebased

@ry

Here's a patch for deno_ns source map support
https://gist.github.com/ry/e35a9f1ddb40e323f0e3ee3d5f66148d

Thanks for addressing everything!

("foo[WILDCARD]baz", "foobazbar", False),
("foo[WILDCARD]baz[WILDCARD]qux", "foobarbazqatqux", True),
("foo[WILDCARD]", "foobar", True),
("foo[WILDCARD]baz[WILDCARD]", "foobarbazqat", True)]

This comment has been minimized.

@ry

ry Aug 10, 2018

Collaborator

Thanks!

@ry

ry Aug 10, 2018

Collaborator

Thanks!

Show outdated Hide outdated tools/util_test.py Outdated
Show outdated Hide outdated tools/util.py Outdated
@kitsonk

This comment has been minimized.

Show comment
Hide comment
@kitsonk

kitsonk Aug 10, 2018

Contributor

@ry ok, everything working now.

Contributor

kitsonk commented Aug 10, 2018

@ry ok, everything working now.

kitsonk added some commits Aug 10, 2018

@ry

ry approved these changes Aug 10, 2018

LGTM - Thank you!

@kitsonk

This comment has been minimized.

Show comment
Hide comment
@kitsonk

kitsonk Aug 10, 2018

Contributor

@ry ok, they are actually re-ordered, but I used git rebase -i and so the timestamps didn't change and GitHub seems to display stuff in timestamp order versus actual commit order. 馃し鈥嶁檪锔

Contributor

kitsonk commented Aug 10, 2018

@ry ok, they are actually re-ordered, but I used git rebase -i and so the timestamps didn't change and GitHub seems to display stuff in timestamp order versus actual commit order. 馃し鈥嶁檪锔

@ry ry merged commit 9be36ff into denoland:master Aug 10, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment