New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Deno::new to return an owned Box #499

Merged
merged 1 commit into from Aug 9, 2018

Conversation

2 participants
@robbym
Contributor

robbym commented Aug 9, 2018

#498
Currently Deno::drop is not being called due to Deno::new not returning an owned type.

@ry

ry approved these changes Aug 9, 2018

LGTM - thanks!

@ry ry merged commit 99932f6 into denoland:master Aug 9, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment