New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only emit declarations for generated files #502

Merged
merged 2 commits into from Aug 10, 2018

Conversation

2 participants
@kitsonk
Contributor

kitsonk commented Aug 10, 2018

I forgot this was a thing until I was reviewing stuff.

--emitDeclarationOnly causes just the .d.ts files to be output, which are the only things we are inlining in the assets.ts anyways. So slightly more efficient and slightly safer that unused code is not generated during the build.

@ry

ry approved these changes Aug 10, 2018 edited

LGTM - Thanks
Is declarationMap needed?

@kitsonk

This comment has been minimized.

Show comment
Hide comment
@kitsonk

kitsonk Aug 10, 2018

Contributor

No, I thought it might be necessary, but it wasn't in the end and I forgot to remove it.

Contributor

kitsonk commented Aug 10, 2018

No, I thought it might be necessary, but it wasn't in the end and I forgot to remove it.

@ry ry merged commit e28d7ab into denoland:master Aug 10, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment