New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust build file cleanup #508

Merged
merged 3 commits into from Aug 13, 2018

Conversation

2 participants
@ry
Collaborator

ry commented Aug 11, 2018

No description provided.

@ry ry changed the title from [wip] Rust gni cleanup to Rust build file cleanup Aug 12, 2018

@ry ry requested a review from piscisaureus Aug 12, 2018

"$rust_build:url",
"//build_extra/flatbuffers/rust:flatbuffers",
":msg_rs",
# Indirect rust depdendencies also need to be listed here:

This comment has been minimized.

@piscisaureus

piscisaureus Aug 13, 2018

Collaborator

Very nice to see this gone.

@piscisaureus

piscisaureus Aug 13, 2018

Collaborator

Very nice to see this gone.

Show outdated Hide outdated build_extra/rust/BUILD.gn Outdated
@piscisaureus

Super happy to see the master deps list gone from /BUILD.gn.
Not so gung-ho on the is_win stuff.

Fix transitive rust deps.
Use a single out_dir for all rust crates.

@ry ry merged commit 02540e5 into master Aug 13, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ry ry deleted the rust_gni_cleanup branch Sep 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment