New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `@internal` with js/timers.ts #511

merged 1 commit into from Aug 13, 2018


2 participants

kitsonk commented Aug 12, 2018

Resolves #510

Actually looking into more, it certainly seems like timers.ts only exports onMessage for testing purposes and therefore can be marked internal, which then elides the gen/msg_generated import.


ry approved these changes Aug 13, 2018

LGTM - Nice fix - thanks!

@ry ry merged commit e9d692e into denoland:master Aug 13, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
license/cla Contributor License Agreement is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment