New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyper deps and get fetch working #512

Merged
merged 3 commits into from Aug 20, 2018

Conversation

4 participants
@ry
Collaborator

ry commented Aug 13, 2018

Continuation of #478

depends on #521

@ry ry referenced this pull request Aug 13, 2018

Closed

[WIP] Implement window.fetch #478

@ry ry changed the base branch from master to rust_gni_cleanup Aug 13, 2018

@ry ry changed the base branch from rust_gni_cleanup to master Aug 13, 2018

@kitsonk

Just a comment about fetch_types.ts

Show outdated Hide outdated js/fetch_types.ts Outdated

@ry ry changed the base branch from master to rust_flatbuffers_upgrade Aug 14, 2018

@ry ry changed the title from [wip] Add hyper deps and get fetch working to Add hyper deps and get fetch working Aug 16, 2018

@ry ry changed the base branch from rust_flatbuffers_upgrade to master Aug 16, 2018

@@ -0,0 +1,426 @@
type HeadersInit = Headers | string[][] | Record<string, string>;

This comment has been minimized.

@piscisaureus

piscisaureus Aug 17, 2018

Collaborator

Where is this file from? It should probably have a copyright notice?
But mostly I'm asking because I don't want to review it...

@piscisaureus

piscisaureus Aug 17, 2018

Collaborator

Where is this file from? It should probably have a copyright notice?
But mostly I'm asking because I don't want to review it...

This comment has been minimized.

@ry

ry Aug 18, 2018

Collaborator

It's copied from typescript's lib.dom.d.ts .. I've added a msft copyright header

@ry

ry Aug 18, 2018

Collaborator

It's copied from typescript's lib.dom.d.ts .. I've added a msft copyright header

ry and others added some commits Aug 15, 2018

First pass at fetch()
With help from Thomas Ghysels <info@thomasg.be>
@piscisaureus

Rubberstamp as requested

@ry ry merged commit 868e8d8 into master Aug 20, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ry ry referenced this pull request Aug 21, 2018

Merged

Fix TS errors in fetch.ts #551

@ry ry deleted the hyper2 branch Sep 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment