New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #404 (change :test_cc to v8_executable) #516

Merged
merged 1 commit into from Aug 14, 2018

Conversation

2 participants
@kt3k
Contributor

kt3k commented Aug 14, 2018

This resolves #404.

This PR changes :test_cc to v8_executable.

@ry

ry approved these changes Aug 14, 2018

Very nice. Thank you for researching this. LGTM.

@ry ry merged commit f46c271 into denoland:master Aug 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@kt3k kt3k deleted the kt3k:feature/suppress-warnings branch Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment