New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust_treat_warnings_as_errors build arg #517

Merged
merged 1 commit into from Aug 14, 2018

Conversation

2 participants
@kt3k
Contributor

kt3k commented Aug 14, 2018

This PR resolves a TODO comment created in #379.

Since the build arg treat_warnings_as_errors is declared in a BUILD.gn file (not a .gni file), I think it's not possible to reuse this arg in deno's .gn/.gni files. (If the arg were declared in .gni file, we could import and use it.)

So I suggest to introduce a new build arg rust_treat_warnings_as_errors for controlling the same thing as treat_warnings_as_errors for rust compilation.

@ry

This comment has been minimized.

Show comment
Hide comment
@ry

ry Aug 14, 2018

Collaborator

So I suggest to introduce a new build arg rust_treat_warnings_as_errors for controlling the same thing as treat_warnings_as_errors for rust compilation.

Sounds good!

Collaborator

ry commented Aug 14, 2018

So I suggest to introduce a new build arg rust_treat_warnings_as_errors for controlling the same thing as treat_warnings_as_errors for rust compilation.

Sounds good!

@ry

ry approved these changes Aug 14, 2018

LGTM - Thanks!

@ry ry merged commit 0ce7b6e into denoland:master Aug 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@kt3k kt3k deleted the kt3k:feature/treat-warnings-as-errors-for-rust branch Aug 15, 2018

@kt3k

This comment has been minimized.

Show comment
Hide comment
@kt3k

kt3k Aug 15, 2018

Contributor

Thanks for merging!

Contributor

kt3k commented Aug 15, 2018

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment