New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download clang-format from Google storage and use it in tools/format.py #532

Merged
merged 1 commit into from Aug 17, 2018

Conversation

2 participants
@kt3k
Copy link
Contributor

kt3k commented Aug 17, 2018

No description provided.

@ry

ry approved these changes Aug 17, 2018

Copy link
Collaborator

ry left a comment

Great - thanks!
LGTM

@@ -1,6 +1,6 @@
#!/usr/bin/env python
import os
from third_party import third_party_path, fix_symlinks, google_env
from third_party import third_party_path, fix_symlinks, google_env, clang_format_path

This comment has been minimized.

@ry

ry Aug 17, 2018

Collaborator

This line is over 80 characters yet yapf didn't format it. It's fine for now. But I think yapf needs to be configured or replaced.

@ry ry merged commit 67d89ff into denoland:master Aug 17, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment