New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change usage example script extension from .js to .ts #549

Merged
merged 1 commit into from Aug 22, 2018

Conversation

5 participants
@jeremyBanks
Contributor

jeremyBanks commented Aug 20, 2018

This caused me a half-second's confusion when I first tried running Deno -- I thought this would run TypeScript directly, but it's asking for a JavaScript file? It looks like .ts examples are used elsewhere in this file's own tests, and the README, so maybe this could be switched to match.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 20, 2018

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 20, 2018

CLA assistant check
All committers have signed the CLA.

@kitsonk

This comment has been minimized.

Show comment
Hide comment
@kitsonk

kitsonk Aug 20, 2018

Contributor

My opinion is that usage should show that JavaScript or TypeScript is supported.

Contributor

kitsonk commented Aug 20, 2018

My opinion is that usage should show that JavaScript or TypeScript is supported.

@ry

ry approved these changes Aug 22, 2018

Ok sure. Thanks.

@ry ry merged commit 27ef77e into denoland:master Aug 22, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@NewLunarFire

This comment has been minimized.

Show comment
Hide comment
@NewLunarFire

NewLunarFire Aug 22, 2018

Usage: script.[js|ts]

NewLunarFire commented Aug 22, 2018

Usage: script.[js|ts]

@ry

This comment has been minimized.

Show comment
Hide comment
@ry

ry Aug 22, 2018

Collaborator

Let's not get pedantic - I'd rather a usage string that's easily readable

Collaborator

ry commented Aug 22, 2018

Let's not get pedantic - I'd rather a usage string that's easily readable

@jeremyBanks jeremyBanks deleted the jeremyBanks:patch-1 branch Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment