Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide required arguments to walk in example. #5668

Merged
merged 1 commit into from May 20, 2020
Merged

Conversation

HoverBaum
Copy link
Contributor

@HoverBaum HoverBaum commented May 20, 2020

Adds the required first parameter to the example.

Just tried running it while exploring Deno and the walk example gave me and error with:

error: TS2554 [ERROR]: Expected 1-2 arguments, but got 0.
  for await (const entry of walk()) {
                            ~~~~~~
    at file:///Users/.../index.ts:5:29

    An argument for 'root' was not provided.
      root: string,
      ~~~~~~~~~~~~
        at https://deno.land/std/fs/walk.ts:86:3

This Pull Request adds the required parameter in the example.

@CLAassistant
Copy link

CLAassistant commented May 20, 2020

CLA assistant check
All committers have signed the CLA.

ry
ry approved these changes May 20, 2020
Copy link
Member

@ry ry left a comment

Thanks!

@ry ry merged commit 765acd3 into denoland:master May 20, 2020
1 check passed
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants