Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(std): add md5 hash #5719

Merged
merged 1 commit into from May 21, 2020
Merged

feat(std): add md5 hash #5719

merged 1 commit into from May 21, 2020

Conversation

@skdltmxn
Copy link
Contributor

@skdltmxn skdltmxn commented May 21, 2020

This PR implements Md5 hash.
Please refer #5558 for API design rationale.

ry
ry approved these changes May 21, 2020
Copy link
Member

@ry ry left a comment

LGTM for a first pass thanks @skdltmxn !

I think at some point we'll need to review all these hash implementations and make sure they work well together. In particular, I think these hash functions should implement Deno.Writer like is done in Go: https://golang.org/pkg/hash/#Hash

@ry ry merged commit 49c85a2 into denoland:master May 21, 2020
7 checks passed
@skdltmxn skdltmxn deleted the std-hash-md5 branch May 21, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this issue Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this issue Jan 24, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this issue Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this issue Jan 31, 2021
caspervonb added a commit to caspervonb/deno_std that referenced this issue Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants