Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add function to delete an environment variable #5859

Merged
merged 4 commits into from Jun 9, 2020

Conversation

@tumile
Copy link
Contributor

tumile commented May 25, 2020

Resolve issue #5812 by adding Deno.env.delete function.

  • Added op_delete_env in cli/ops/os.rs
  • Added deleteEnv TS wrapper in cli/js/ops/os.ts and its type declaration in cli/js/lib.deno.ns.d.ts
  • Added deleteEnv unit test in cli/tests/unit/os_test.ts
Deno.env.set("key", "value");
Deno.env.delete("key");
@CLAassistant
Copy link

CLAassistant commented May 25, 2020

CLA assistant check
All committers have signed the CLA.

@tumile tumile changed the title Add function to delete an environment variable feat(cli): Add function to delete an environment variable May 25, 2020
@bartlomieju bartlomieju added this to the 1.1.0 milestone May 26, 2020
@bartlomieju bartlomieju changed the base branch from master to v1.1 May 26, 2020
@ry ry force-pushed the tumile:master branch from 8fa0c60 to 83de9de May 26, 2020
@ry
ry approved these changes May 26, 2020
Copy link
Collaborator

ry left a comment

LGTM - thanks @tumile, nice work.

This will be included in the 1.1.0 release, which we expect some time in June.

@ry ry closed this Jun 6, 2020
@nayeemrmn
Copy link
Contributor

nayeemrmn commented Jun 6, 2020

This one was also closed unintentionally.

@ry ry reopened this Jun 6, 2020
@ry
ry approved these changes Jun 6, 2020
Copy link
Collaborator

ry left a comment

LGTM - thank you !

@ry ry changed the base branch from v1.1 to master Jun 6, 2020
@bartlomieju
Copy link
Contributor

bartlomieju commented Jun 8, 2020

@ry please land this PR

bartlomieju added 2 commits Jun 9, 2020
@bartlomieju bartlomieju merged commit 878f306 into denoland:master Jun 9, 2020
7 checks passed
7 checks passed
test_release macOS-latest
Details
test_release windows-2019
Details
test_release ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.