New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libdeno.setGlobalErrorHandler #605

Merged
merged 1 commit into from Aug 26, 2018

Conversation

2 participants
@kt3k
Copy link
Contributor

kt3k commented Aug 26, 2018

This PR tries to resolve #553.

  • I added libdeno.setGlobalErrorHandler and replaced the use of window.onerror with it.
  • Updated the test cases of handling of uncaught errors.
@ry

ry approved these changes Aug 26, 2018

Copy link
Collaborator

ry left a comment

LGTM - perfectly done - thank you @kt3k!

@ry ry merged commit 17d6d6b into denoland:master Aug 26, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@kt3k kt3k deleted the kt3k:feature/set-global-error-handler branch Aug 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment