Skip to content

/ deno

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(std): add std/node/os/totalmem, freemem #8317

Merged
merged 4 commits into from Nov 19, 2020
Merged

feat(std): add std/node/os/totalmem, freemem #8317

merged 4 commits into from Nov 19, 2020

Conversation

@jopemachine
Copy link
Contributor

@jopemachine jopemachine commented Nov 9, 2020

Related Issue

#3802

Notes

  • I would appreciate it if you let me know if we have any other works to do like creating some documents :)
jopemachine added 2 commits Nov 9, 2020
@jopemachine
Add totalmem, freemem using Deno.systemMemoryInfo
c15b7b8
@jopemachine
Update os_test.ts
Loading status checks…
ab6e7e8
@jopemachine jopemachine marked this pull request as draft Nov 9, 2020
@ry
Copy link
Member

@ry ry commented Nov 9, 2020

Thanks for the patch - looks good. Please merge with master branch because currently there's a conflict in std/node/os.ts
jopemachine added 2 commits Nov 10, 2020
@jopemachine
Resolve conflict
cf5501f
@jopemachine
Merge branch 'master' of https://github.com/denoland/deno into feat-n…
Loading status checks…
8663fc6 
…ode-memoryInfo
@jopemachine jopemachine marked this pull request as ready for review Nov 10, 2020
@ry
ry approved these changes Nov 19, 2020
View changes
Copy link
Member

@ry ry left a comment

Thanks! LGTM
@ry ry merged commit d5772a9 into denoland:master Nov 19, 2020
7 checks passed
7 checks passed
test_release macos-10.15
Details
test_release windows-2019
Details
test_release ubuntu-latest-xl
Details
test_debug ubuntu-latest-xl
Details
bench ubuntu-latest-xl
Details
lint ubuntu-latest-xl
Details
license/cla Contributor License Agreement is signed.
Details
jannes added a commit to jannes/deno that referenced this pull request Dec 1, 2020
@jopemachine @jannes
feat(std/node): add os.totalmem, os.freemem (denoland#8317)
d3e5176
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@jopemachine
feat(std/node): add os.totalmem, os.freemem (denoland/deno#8317)
d2c4ea1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jopemachine @ry