Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(std): add std/node/os/totalmem, freemem #8317

Merged
merged 4 commits into from Nov 19, 2020

Conversation

@jopemachine
Copy link
Contributor

@jopemachine jopemachine commented Nov 9, 2020

Related Issue

#3802

Notes

  • I would appreciate it if you let me know if we have any other works to do like creating some documents :)
@jopemachine jopemachine marked this pull request as draft Nov 9, 2020
@ry
Copy link
Member

@ry ry commented Nov 9, 2020

Thanks for the patch - looks good. Please merge with master branch because currently there's a conflict in std/node/os.ts

@jopemachine jopemachine marked this pull request as ready for review Nov 10, 2020
@ry
ry approved these changes Nov 19, 2020
Copy link
Member

@ry ry left a comment

Thanks! LGTM

@ry ry merged commit d5772a9 into denoland:master Nov 19, 2020
7 checks passed
7 checks passed
test_release macos-10.15
Details
test_release windows-2019
Details
test_release ubuntu-latest-xl
Details
test_debug ubuntu-latest-xl
Details
bench ubuntu-latest-xl
Details
lint ubuntu-latest-xl
Details
license/cla Contributor License Agreement is signed.
Details
jannes added a commit to jannes/deno that referenced this pull request Dec 1, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants