New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(webapp): stop hard coding benchmark column names #932

Merged
merged 1 commit into from Oct 7, 2018

Conversation

2 participants
@kt3k
Copy link
Contributor

kt3k commented Oct 7, 2018

This PR implements the improvement of the benchmark viewer script which is suggested in #889 (comment).

Now //webapp/app.js guesses the column names for each benchmark from the last record in the data. Now we can add a new column by just modifying //tools/benchmark.py.

(I chose the last record for guessing the column name because this would be convenient if we want to stop seeing some of the columns. In that case we can just remove the column from the latest benchmark data and the column disappears in the page.)

@ry

ry approved these changes Oct 7, 2018

Copy link
Collaborator

ry left a comment

Great! No comments. LGTM

@ry ry merged commit 1aa7e18 into denoland:master Oct 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment