Skip to content

refactor: upgrade to deno_ast 0.15#153

Merged
dsherret merged 5 commits intodenoland:mainfrom
dsherret:deno_ast_15
May 20, 2022
Merged

refactor: upgrade to deno_ast 0.15#153
dsherret merged 5 commits intodenoland:mainfrom
dsherret:deno_ast_15

Conversation

@dsherret
Copy link
Member

No description provided.

"./a.js",
{
"start": 62,
"end": 68,
Copy link
Member Author

@dsherret dsherret May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Positions were wrong it seems. For verifying positions, I recommend putting code into https://ts-ast-viewer.com and then looking at the "Pos" number in the bottom left.

@dsherret dsherret marked this pull request as ready for review May 20, 2022 15:18
@dsherret dsherret requested a review from bartlomieju May 20, 2022 15:18
@dsherret dsherret changed the title refactor: upgrade for deno_ast 0.15 refactor: upgrade to deno_ast 0.15 May 20, 2022
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this upgrade is very painful

@dsherret dsherret merged commit 35e7e52 into denoland:main May 20, 2022
@dsherret dsherret deleted the deno_ast_15 branch May 20, 2022 16:49
@dsherret
Copy link
Member Author

Forgot to bump the Wasm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants