Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-var): add "recommended" tag to no-var #813

merged 1 commit into from Aug 23, 2021


Copy link

This PR adds no-var to the recommended set of rules.

no-var is currently not in the recommended set simply because ESLint's recommended set doesn't include the rule either. Not really sure why ESLint doesn't, but given that this rule is considered to be always useful when writing TypeScript/JavaScript in modern fashion, we should probably make it "recommended".

Copy link

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and saw discussion on discord.

@dsherret dsherret merged commit 1384aa5 into denoland:main Aug 23, 2021
@magurotuna magurotuna deleted the make-no-var-recommended branch August 23, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants