feat(no-var): add "recommended" tag to no-var - #813
Merged
Conversation
dsherret
approved these changes
Aug 23, 2021
dsherret
left a comment
dsherret
left a comment
Contributor
There was a problem hiding this comment.
LGTM and saw discussion on discord.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
no-varto the recommended set of rules.no-varis currently not in the recommended set simply because ESLint's recommended set doesn't include the rule either. Not really sure why ESLint doesn't, but given that this rule is considered to be always useful when writing TypeScript/JavaScript in modern fashion, we should probably make it "recommended".