Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(no-import-assign): remove its own scope analyzer #821

Conversation

magurotuna
Copy link
Member

This PR removes the rule-dedicated scope analyzer from no-import-assign, and instead lets it use the common scope analyzer.

Towards #492

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup 👍

@bartlomieju bartlomieju merged commit c679543 into denoland:main Aug 29, 2021
@magurotuna magurotuna deleted the refactor/use-common-scope-analyzer-in-no-import-assign branch August 30, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants