Skip to content

refactor(no-global-assign): remove its own scope analyzer - #822

Merged
bartlomieju merged 3 commits into
denoland:mainfrom
magurotuna:refactor/use-common-scope-analyzer-in-no-global-assign
Aug 29, 2021
Merged

refactor(no-global-assign): remove its own scope analyzer#822
bartlomieju merged 3 commits into
denoland:mainfrom
magurotuna:refactor/use-common-scope-analyzer-in-no-global-assign

Conversation

@magurotuna

Copy link
Copy Markdown
Member

This PR removes the rule-dedicated scope analyzer from no-global-assign, and instead lets it use the common scope analyzer.

Towards #492

@bartlomieju bartlomieju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju
bartlomieju merged commit 64bb9c1 into denoland:main Aug 29, 2021
@magurotuna
magurotuna deleted the refactor/use-common-scope-analyzer-in-no-global-assign branch August 30, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants