fix(no-window-prefix): switch from allow-list to deny-list #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Sep 9, 2021
Member
bartlomieju
left a comment
bartlomieju
left a comment
There was a problem hiding this comment.
@lucacasonato does this change satisfy your needs?
lucacasonato
approved these changes
Sep 9, 2021
Member
lucacasonato
left a comment
lucacasonato
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the quick fix @magurotuna :-)
bartlomieju
approved these changes
Sep 9, 2021
Member
bartlomieju
left a comment
bartlomieju
left a comment
There was a problem hiding this comment.
LGTM, thank you @magurotuna
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets
no-window-prefixrule use a deny-list instead of allow-list when checking if the property is considered valid or not.It's possible to check if the deny-list is always up-to-date by running
tools/generate_no_window_prefix_deny_list.tsin CI, but I am not sure if such a rigid approach is needed.Fixes #850