Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prefer-ascii): print character's unicode code point in hint #857

Merged
merged 2 commits into from
Sep 11, 2021

Conversation

magurotuna
Copy link
Member

This PR adds a character's unicode code point to hint, and upgrades annotate-snippets to 0.9.1 so that diagnostics point to the right position when the target character is double-width.

Closes #852

Before

image

After

image

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bartlomieju bartlomieju merged commit 7825cb9 into denoland:main Sep 11, 2021
@magurotuna magurotuna deleted the fix-prefer-ascii branch September 12, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefer-ascii: Show \x... value on non-ascii character in hint
2 participants