Update webhook to accept x-www-form-urlencoded requests #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor content-type verification to the main handler instead of in each integration. Add tests for form urlencoded cases. Add utils function to generate mock web-form APIGateway event. Fixes denoland#33
lucacasonato
reviewed
Aug 9, 2020
Split b64 decoding and form URL decode Co-authored-by: Luca Casonato <luca.casonato@antipy.com>
lucacasonato
approved these changes
Aug 9, 2020
There was a problem hiding this comment.
I just tested this in a staging environment and it works great. Thanks @wperron!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor content-type verification to the main handler instead of in each
integration. Add tests for form urlencoded cases. Add utils function
to generate mock web-form APIGateway event.
Fixes #33