New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reusable prettier wrapper CLI #165

Merged
merged 2 commits into from Feb 1, 2019

Conversation

3 participants
@kt3k
Copy link
Contributor

kt3k commented Jan 30, 2019

Created reusable formatter at //prettier/main.ts. You can use it like:

deno --allow-run --allow-write https://deno.land/x/std/prettier/main.ts

See //prettier/README.md for more details.


close #159

@kt3k kt3k force-pushed the kt3k:feature/prettier-main branch from a1d9d95 to 1cd399a Jan 31, 2019

@kt3k

This comment has been minimized.

Copy link
Contributor Author

kt3k commented Jan 31, 2019

CI is red because deno.exe is not available in PATH on windows. (task.prependpath doesn't seem working only on windows...

@ry

This comment has been minimized.

Copy link
Contributor

ry commented Jan 31, 2019

Hmmmm I wonder what changed - it was working...
@MarkTiedemann any ideas about this windows CI issue?

@kt3k kt3k force-pushed the kt3k:feature/prettier-main branch 3 times, most recently from 423bed9 to b1f9b82 Jan 31, 2019

@kt3k kt3k force-pushed the kt3k:feature/prettier-main branch from b1f9b82 to 9638aad Jan 31, 2019

@kt3k

This comment has been minimized.

Copy link
Contributor Author

kt3k commented Jan 31, 2019

I'm not sure this is ideal, but I changed the some steps in windows job from script to bash, and now CI passes.

(The document says script step uses cmd.exe on windows, and bash step uses Git Bash on windows.)

@MarkTiedemann

This comment has been minimized.

Copy link
Contributor

MarkTiedemann commented Feb 1, 2019

Hmmmm I wonder what changed - it was working...
@MarkTiedemann any ideas about this windows CI issue?

No idea. I might be able to investigate more deeply tomorrow when I have access to my Windows machine again.

I don't think any changes to deno_install caused this issue.

@ry

ry approved these changes Feb 1, 2019

Copy link
Contributor

ry left a comment

LGTM - this is great - thanks @kt3k! I'm really looking forward to having deno script.ts --fmt

I think the next step is to remove prettier usage from core's tools/format.ts and use this instead.

(Regarding the CI - I also don't know what's happening here. But let's just land it since it's working.)

@ry ry merged commit e7837ff into denoland:master Feb 1, 2019

2 checks passed

denoland.deno_std #20190131.5 succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@kt3k kt3k deleted the kt3k:feature/prettier-main branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment