Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing default parameters of runBenchmarks #229

Merged
merged 1 commit into from Mar 4, 2019
Merged

Fixing default parameters of runBenchmarks #229

merged 1 commit into from Mar 4, 2019

Conversation

zekth
Copy link
Contributor

@zekth zekth commented Mar 4, 2019

Fixing : #228

chiefbiiko
chiefbiiko reviewed Mar 4, 2019
View reviewed changes
benching/mod.ts Outdated Show resolved Hide resolved
ry
ry approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit facc8ce into denoland:master Mar 4, 2019
@chiefbiiko chiefbiiko mentioned this pull request Mar 4, 2019
Closed
@zekth zekth deleted the runBenchmarks_fix branch March 4, 2019 17:20
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@zekth @ry
Fixing default parameters of runBenchmarks (denoland/deno_std#229)
87d044e 
Original: denoland/deno_std@facc8ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiefbiiko chiefbiiko chiefbiiko left review comments

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zekth @ry @chiefbiiko