Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing refactor #240

Merged
merged 14 commits into from Mar 6, 2019

Conversation

2 participants
@zekth
Copy link
Contributor

zekth commented Mar 6, 2019

As mentionned in #237

Refactoring all the asserts exposed in mod.ts to asserts.ts

@@ -17,7 +44,11 @@ export function assert(expr: boolean, msg = ""): void {
* Make an assertion that `actual` and `expected` are equal, deeply. If not
* deeply equal, then throw.
*/
export function equal(actual: unknown, expected: unknown, msg?: string): void {
export function assertEqual(

This comment has been minimized.

@ry

ry Mar 6, 2019

Contributor

Please rename this to assertEq

equal
} from "https://deno.land/x/testing/mod.ts";
import { runTests, test, equal } from "https://deno.land/x/testing/mod.ts";
import { assert } from "https://deno.land/x/testing/asserts.ts";

This comment has been minimized.

@ry

ry Mar 6, 2019

Contributor
  1. Use https://deno.land/std/testing/asserts.ts (without /x/)

  2. Use assertEq("hello", "world") here rather than assert(equal("hello", "world"))

zekth and others added some commits Mar 6, 2019

fix
fmt
@ry

ry approved these changes Mar 6, 2019

Copy link
Contributor

ry left a comment

LGTM - thanks!

@ry ry merged commit e1d5c00 into denoland:master Mar 6, 2019

2 checks passed

denoland.deno_std #20190306.10 succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@zekth zekth deleted the zekth:testing_refactor branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.