Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename assertEq to assertEquals #242

Merged
merged 1 commit into from Mar 7, 2019

Conversation

2 participants
@ry
Copy link
Contributor

ry commented Mar 7, 2019

After some discussion it was found that assertEquals is more common
in JS (vs assertEqual, assertEq) and sounds better in the negated form:
assertNotEquals vs assertNE.

Rename assertEq to assertEquals
After some discussion it was found that assertEquals is more common
in JS (vs assertEqual, assertEq) and sounds better in the negated form:
assertNotEquals vs assertNE.

@ry ry requested a review from piscisaureus Mar 7, 2019

@piscisaureus
Copy link
Contributor

piscisaureus left a comment

👍🏿

@ry ry merged commit 4cf39d4 into denoland:master Mar 7, 2019

2 checks passed

denoland.deno_std #20190307.1 succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@ry ry deleted the ry:assert_equals branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.