Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ensureSymlink/ensureSymlinkSync for fs modules #268

Merged
merged 17 commits into from Apr 21, 2019

Conversation

3 participants
@axetroy
Copy link
Contributor

commented Mar 13, 2019

part of #261

not implement in Windows now.

@axetroy axetroy referenced this pull request Mar 13, 2019

Closed

implement fs-extra api for fs modules #261

12 of 13 tasks complete

@axetroy axetroy changed the title feat: add ensure_syslink for fs feat: add ensureSyslink/ensureSyslinkSnc for fs Mar 13, 2019

@axetroy axetroy changed the title feat: add ensureSyslink/ensureSyslinkSnc for fs feat: add ensureSyslink/ensureSyslinkSync for fs modules Mar 14, 2019

@zekth
Copy link
Contributor

left a comment

rename from Syslink to Symlink

Show resolved Hide resolved fs/ensure_syslink_test.ts Outdated

axetroy added some commits Mar 14, 2019

@axetroy axetroy changed the title feat: add ensureSyslink/ensureSyslinkSync for fs modules feat: add ensureSymlink/ensureSymlinkSync for fs modules Mar 14, 2019

@zekth
Copy link
Contributor

left a comment

I don't think Should skip is a good solution. I'd test assertThrows(ensureSymlink()) if deno.platform === 'win'

@axetroy

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

I don't think Should skip is a good solution. I'd test assertThrows(ensureSymlink()) if deno.platform === 'win'

or should wait for support windows?

@axetroy axetroy changed the title feat: add ensureSymlink/ensureSymlinkSync for fs modules [WPI] feat: add ensureSymlink/ensureSymlinkSync for fs modules Mar 18, 2019

@axetroy axetroy changed the title [WPI] feat: add ensureSymlink/ensureSymlinkSync for fs modules [WIP] feat: add ensureSymlink/ensureSymlinkSync for fs modules Mar 18, 2019

axetroy added some commits Apr 14, 2019

@zekth

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

You may have to do a conditionnal if(win) in the tests due to the notimplemend status. No? Seems legit to me.

@axetroy axetroy changed the title [WIP] feat: add ensureSymlink/ensureSymlinkSync for fs modules feat: add ensureSymlink/ensureSymlinkSync for fs modules Apr 21, 2019

@axetroy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

@zekth Yes. you are right.

I found that denoland/deno has many places to write like this, I should change it.

@ry

ry approved these changes Apr 21, 2019

Copy link
Contributor

left a comment

LGTM

@ry ry merged commit 8d1b01c into denoland:master Apr 21, 2019

2 checks passed

denoland.deno_std #20190421.4 succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@axetroy axetroy deleted the axetroy:ensure_syslink branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.