Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: add copy/copySync for fs modules #278

Open
wants to merge 4 commits into
base: master
from

Conversation

3 participants
@axetroy
Copy link
Contributor

axetroy commented Mar 14, 2019

part of #261

axetroy added some commits Mar 14, 2019

@axetroy axetroy referenced this pull request Mar 14, 2019

Open

implement fs-extra api for fs modules #261

7 of 13 tasks complete
Show resolved Hide resolved fs/copy.ts Outdated
overwrite?: boolean;
}

function isSrcSubdir(src: string, dest: string): boolean {

This comment has been minimized.

@axetroy

axetroy Mar 14, 2019

Author Contributor

there are two isSrcSubdir method in the fs modules

Should it be extracted into path modules?

This comment has been minimized.

@ry

ry Mar 14, 2019

Contributor

What does it do? Please add JSDoc.

And yes, we should not duplicate functionality.

axetroy added some commits Mar 16, 2019

@axetroy

This comment has been minimized.

Copy link
Contributor Author

axetroy commented Mar 17, 2019

I am implementing copy link file

Here's a problem:

  1. Deno does not have API to update files'creation time now. denoland/deno#1948
  2. Deno does not have an API to delete the link file denoland/deno#1947

@axetroy axetroy changed the title feat: add copy/copySync for fs modules [WIP] feat: add copy/copySync for fs modules Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.