Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs): add copy/copySync #278

Merged
merged 30 commits into from May 16, 2019

Conversation

3 participants
@axetroy
Copy link
Contributor

commented Mar 14, 2019

part of #261

axetroy added some commits Mar 14, 2019

@axetroy axetroy referenced this pull request Mar 14, 2019

Closed

implement fs-extra api for fs modules #261

12 of 13 tasks complete
Show resolved Hide resolved fs/copy.ts Outdated
Show resolved Hide resolved fs/copy.ts Outdated
@axetroy

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

I am implementing copy link file

Here's a problem:

  1. Deno does not have API to update files creation time now. denoland/deno#1948
  2. Deno does not have an API to delete the link file denoland/deno#1947

@axetroy axetroy changed the title feat: add copy/copySync for fs modules [WIP] feat: add copy/copySync for fs modules Mar 18, 2019

@axetroy axetroy changed the title [WIP] feat: add copy/copySync for fs modules [WIP] feat(fs): add copy/copySync for fs modules May 1, 2019

axetroy added some commits May 13, 2019

@axetroy axetroy changed the title [WIP] feat(fs): add copy/copySync for fs modules feat(fs): add copy/copySync May 15, 2019

@axetroy

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

/cc @ry ready for review

Show resolved Hide resolved fs/copy.ts Outdated
Show resolved Hide resolved fs/copy_test.ts

@zekth zekth referenced this pull request May 16, 2019

Closed

Consider porting path.swift #392

Show resolved Hide resolved fs/copy_test.ts Outdated
Show resolved Hide resolved fs/copy_test.ts Outdated
Show resolved Hide resolved fs/copy_test.ts Outdated
Show resolved Hide resolved fs/copy_test.ts Outdated
Show resolved Hide resolved fs/copy_test.ts Outdated
@axetroy

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

By the way

Because the test files are too large and difficult to review.

Is it possible to separate synchronous and asynchronous tests?

// copy_test.ts
import "./copy_async_test.ts"
import "./copy_sync_test.ts"
@ry

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

@axetroy I don't mind big files. I'd prefer you keep related code together. But I leave it up to you.

@ry

ry approved these changes May 16, 2019

Copy link
Contributor

left a comment

LGTM - nice work!

@ry ry merged commit ab5b088 into denoland:master May 16, 2019

5 checks passed

denoland.deno_std Build #20190516.5 succeeded
Details
denoland.deno_std (Linux) Linux succeeded
Details
denoland.deno_std (Mac) Mac succeeded
Details
denoland.deno_std (Windows) Windows succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@axetroy axetroy deleted the axetroy:copy branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.