Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Benchmarks not returning on deno 0.3.4+ #317

Merged
merged 6 commits into from Mar 30, 2019

Conversation

3 participants
@ATheCoder
Copy link
Contributor

commented Mar 30, 2019

This addresses #316 (reference)

@CLAassistant

This comment has been minimized.

Copy link

commented Mar 30, 2019

CLA assistant check
All committers have signed the CLA.

@ry

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

Thanks - please re-enable the benchmark test too.

// TODO(ry) Re-enable these tests - they are causing the a hang.

@ry

ry approved these changes Mar 30, 2019

Copy link
Contributor

left a comment

LGTM - thanks

@ry ry merged commit a1ceaa6 into denoland:master Mar 30, 2019

2 checks passed

denoland.deno_std #20190330.6 succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@ATheCoder ATheCoder deleted the ATheCoder:banchmark-patch branch Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.