Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertSetEquals and assertNotSetEquals #350

Merged
merged 4 commits into from Apr 22, 2019

Conversation

2 participants
@sh7dm
Copy link
Contributor

commented Apr 20, 2019

Fixes #349.

Co-authored-by: @johnsonjo4531

sh7dm added some commits Apr 20, 2019

Add assertSetEquals and assertNotSetEquals
Co-authored-by: johnsonjo4531
@sh7dm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2019

Note for maintainers: please add @johnsonjo4531 as a co-author when merging

@ry

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2019

I would expect assertEquals to do this. Can this be worked into the equals() function?

@sh7dm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

@ry, OK, let me do this tomorrow plz. It's late now, 💤

@sh7dm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

@ry fixed.

@ry

ry approved these changes Apr 22, 2019

Copy link
Contributor

left a comment

LGTM - thanks - nice patch

@ry

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

oops - it's red still.

@sh7dm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

Formatting...

@sh7dm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

@ry done

@ry ry merged commit 9432d70 into denoland:master Apr 22, 2019

2 checks passed

denoland.deno_std #20190422.13 succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@sh7dm sh7dm deleted the sh7dm:set-equals branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.