Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[encoding] add csv parse #458

Merged
merged 11 commits into from May 30, 2019

Conversation

2 participants
@zekth
Copy link
Contributor

commented May 27, 2019

Ported https://github.com/zekth/deno_easyCSV to encoding/csv.
Also added the possibility to use BufReader as input and not only string.

ref: #455

@ry

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

Cool - looks good - but I'm holding for #444.

@ry
Copy link
Contributor

left a comment

Can you update encoding/README.md too?

@zekth zekth force-pushed the zekth:add_csv_parse branch from 3ba62ac to ffdcaba May 30, 2019

@zekth

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Rebased.
Passes tests but still have the uTime problem on the MacOs ci

@ry

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

uTime problem on the MacOs ci

What's that? Can you submit a PR to disable it until we have a fix?

@zekth

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

uTime problem on the MacOs ci

What's that? Can you submit a PR to disable it until we have a fix?

here are the related issues:
denoland/deno#2411
#421

i'll disable the test so.

@zekth zekth force-pushed the zekth:add_csv_parse branch from ffdcaba to bee8b06 May 30, 2019

Show resolved Hide resolved fs/copy_test.ts Outdated
@ry

ry approved these changes May 30, 2019

Copy link
Contributor

left a comment

LGTM

@ry ry merged commit 167f529 into denoland:master May 30, 2019

5 checks passed

denoland.deno_std Build #20190530.8 succeeded
Details
denoland.deno_std (Linux) Linux succeeded
Details
denoland.deno_std (Mac) Mac succeeded
Details
denoland.deno_std (Windows) Windows succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@zekth zekth deleted the zekth:add_csv_parse branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.