Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle loader #480

Merged
merged 5 commits into from Jun 10, 2019

Conversation

2 participants
@kitsonk
Copy link
Contributor

commented Jun 5, 2019

Related to denoland/deno#2357.

I am working on adding bundles to Deno, but for the first version @ry and I discussed that we would not build loading directly into Deno, so the bundle/run.ts module can load bundles that will be generated by Deno, evaluate them and instantiate them.

There is an example bundle included in this PR, so to try locally:

deno run ./bundle/run.ts ./bundle/testdata/bundle.js

I need to add tests before this is ready for merging.

kitsonk added some commits Jun 5, 2019

@kitsonk kitsonk changed the title [WIP] Add bundle loader Add bundle loader Jun 6, 2019

@kitsonk kitsonk marked this pull request as ready for review Jun 6, 2019

kitsonk added some commits Jun 7, 2019

@kitsonk kitsonk referenced this pull request Jun 7, 2019

Merged

Add 'bundle' subcommand. #2467

1 of 1 task complete
@kitsonk

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

@ry probably want to merge this while updating to v0.8.0

@ry

ry approved these changes Jun 10, 2019

Copy link
Contributor

left a comment

LGTM - no comments - this is cool

@ry ry merged commit fe7f6e1 into denoland:master Jun 10, 2019

5 checks passed

denoland.deno_std Build #20190607.3 succeeded
Details
denoland.deno_std (Linux) Linux succeeded
Details
denoland.deno_std (Mac) Mac succeeded
Details
denoland.deno_std (Windows) Windows succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.