Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userHomeDir #521

Merged
merged 1 commit into from Jun 24, 2019

Conversation

3 participants
@ekaragodin
Copy link
Contributor

commented Jun 24, 2019

No description provided.

@ekaragodin ekaragodin force-pushed the ekaragodin:add-os-user-home-dir branch 2 times, most recently from 80d8194 to 9346ca5 Jun 24, 2019

* On Unix, including macOS, it returns the $HOME environment variable.
* On Windows, it returns %USERPROFILE%.
*
* Ported from Go: https://github.com/golang/go/blob/go1.12.5/src/os/file.go#L389

This comment has been minimized.

Copy link
@ry

ry Jun 24, 2019

Contributor

Add "Needs permissions to access env (--allow-env)."

This comment has been minimized.

Copy link
@ekaragodin

ekaragodin Jun 24, 2019

Author Contributor

Done.

@ekaragodin ekaragodin force-pushed the ekaragodin:add-os-user-home-dir branch from 9346ca5 to f7ea043 Jun 24, 2019

@ry

ry approved these changes Jun 24, 2019

Copy link
Contributor

left a comment

LGTM - thanks!

@ry ry merged commit ff7fb5a into denoland:master Jun 24, 2019

5 checks passed

denoland.deno_std Build #20190624.26 succeeded
Details
denoland.deno_std (Linux) Linux succeeded
Details
denoland.deno_std (Mac) Mac succeeded
Details
denoland.deno_std (Windows) Windows succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@axetroy

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

it looks superfluous for me.

Isn't it better to implement in Deno.homedir()?

@ry

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

@axetroy I was thinking that too. We would be able to avoid the env access by adding an op.

@ekaragodin

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2019

@ry I don't have enough experience with rust, but I tried denoland/deno#2578

@ekaragodin ekaragodin deleted the ekaragodin:add-os-user-home-dir branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.