Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shebangs Linux compatible #545

Merged
merged 2 commits into from Jul 28, 2019

Conversation

@nayeemrmn
Copy link
Contributor

commented Jul 25, 2019

Fixes #544

This makes the shebangs work with GNU coreutils 8.30+ where /usr/bin/env supports the '-S' option.

It should still work with macOS based on the manual pages I've read but can I get verification on this?

@CLAassistant

This comment has been minimized.

Copy link

commented Jul 25, 2019

CLA assistant check
All committers have signed the CLA.

@ry

ry approved these changes Jul 28, 2019

Copy link
Contributor

left a comment

I'm glad you have found a fix for this! it was always bothering me in the back of my mind. Thanks @nayeem-rahman

LGTM

@ry ry merged commit 5e77e8a into denoland:master Jul 28, 2019

5 checks passed

denoland.deno_std Build #20190726.1 succeeded
Details
denoland.deno_std (Linux) Linux succeeded
Details
denoland.deno_std (Mac) Mac succeeded
Details
denoland.deno_std (Windows) Windows succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.