Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print out the failed tests after the summary #554

Merged
merged 6 commits into from Aug 22, 2019

Conversation

@oygen87
Copy link
Contributor

commented Aug 8, 2019

We have 575 tests and it is a problem to scroll up the terminal to see which tests failed.
So I added a summary of all the failed tests down under with a red label next to them.

These changes will only affect cases when we have failed tests (If all tests pass, it will look like before.)

Also some refactoring to use existing TestResult model and populate it with the test results. We only initialized it before when going Serial testing and could not extract the details from each test afterwards.

proposed look :
deno-test-runner2

oygen87 added 3 commits Aug 8, 2019

@oygen87 oygen87 changed the title print out the failed tests after the summary [WIP] print out the failed tests after the summary Aug 9, 2019

Populate and use TestResult. option to show error.
use existing model that didnt get populated with test results. only initialized to default values. 
Show error message underneith aswell, but added option so we can turn it off. 
but usually we want to know what the error is and not only the name(just like when we run the tests and print out the error, now we see them at the bottom summary too)

@oygen87 oygen87 changed the title [WIP] print out the failed tests after the summary print out the failed tests after the summary Aug 9, 2019

testing/mod.ts Outdated Show resolved Hide resolved
testing/mod.ts Outdated Show resolved Hide resolved
@ry

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Cool - looks good. I will wait for #556 before landing this one.

@ry

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

@ry
ry approved these changes Aug 22, 2019
Copy link
Contributor

left a comment

LGTM too

@ry ry merged commit ed1b9e0 into denoland:master Aug 22, 2019

5 checks passed

denoland.deno_std Build #20190810.1 succeeded
Details
denoland.deno_std (Linux) Linux succeeded
Details
denoland.deno_std (Mac) Mac succeeded
Details
denoland.deno_std (Windows) Windows succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.