Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept absolute root directories in the file server #558

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@nayeemrmn
Copy link
Contributor

commented Aug 9, 2019

Closes #557.

Also some refactors:

  • path utility functions are used where appropriate.
  • I had some difficulty along the way with some variable names so I made them more consistent. A filePath/dirPath is an absolute FS path to a file or directory, whereas fileUrl/dirUrl is a syntactically absolute path but relative to the served root, consistent with req.url. The latter were confusingly called fileName/dirName before.

@nayeemrmn nayeemrmn force-pushed the nayeemrmn:file-server-abs-target branch 3 times, most recently from 7f126ac to e894e8e Aug 9, 2019

@nayeemrmn nayeemrmn force-pushed the nayeemrmn:file-server-abs-target branch from e894e8e to db6b3d6 Aug 15, 2019

@ry
ry approved these changes Aug 15, 2019
Copy link
Contributor

left a comment

LGTM

@ry ry merged commit 262d957 into denoland:master Aug 15, 2019

5 checks passed

denoland.deno_std Build #20190815.5 succeeded
Details
denoland.deno_std (Linux) Linux succeeded
Details
denoland.deno_std (Mac) Mac succeeded
Details
denoland.deno_std (Windows) Windows succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@nayeemrmn nayeemrmn deleted the nayeemrmn:file-server-abs-target branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.