Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use AssertionError in assertEqual #560

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@bartlomieju
Copy link
Contributor

commented Aug 12, 2019

Closes #555

I merged testing/asserts.ts and testing/pretty.ts - both files were short so there's really no need to split them.

Note that this PR is blocked by #556

@bartlomieju bartlomieju force-pushed the bartlomieju:fix-pretty_assert branch from a001b3d to acecbdf Aug 14, 2019

@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@ry should be landable

@ry
ry approved these changes Aug 14, 2019
Copy link
Contributor

left a comment

LGTM

@bartlomieju Can you draft a commit message? This is a bit more than using just AssertionError.

refactor 'assertEquals'
* merge 'testing/pretty.ts' into 'testing/asserts.ts'

* throw AssertionError in assertEquals

* update misc tests use AssertionError

@bartlomieju bartlomieju force-pushed the bartlomieju:fix-pretty_assert branch from f28be6d to 9cd711f Aug 14, 2019

@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@ry rebased and added commit message: 9cd711f

@ry ry merged commit ff2d7f2 into denoland:master Aug 14, 2019

5 checks passed

denoland.deno_std Build #20190814.7 succeeded
Details
denoland.deno_std (Linux) Linux succeeded
Details
denoland.deno_std (Mac) Mac succeeded
Details
denoland.deno_std (Windows) Windows succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bartlomieju bartlomieju deleted the bartlomieju:fix-pretty_assert branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.