Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump prettier to 1.18.2 #592

Merged
merged 4 commits into from Sep 12, 2019

Conversation

@axetroy
Copy link
Contributor

commented Sep 11, 2019

refs: #591

@bartlomieju

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Should there be so many changes after the upgrade of prettier? I'd expect not to reformat any files... 🤔

@axetroy

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@bartlomieju
Prettier does need to reformat the file after the upgrade.

But this upgrade got a strange thing, I can run the test locally, but it does not pass in CI.

@axetroy axetroy force-pushed the axetroy:prettier_1.8.2 branch from de48619 to 27af57f Sep 11, 2019
prettier/vendor/standalone.js Outdated Show resolved Hide resolved
@ry
ry approved these changes Sep 12, 2019
Copy link
Contributor

left a comment

LGTM

@ry ry merged commit 06958a4 into denoland:master Sep 12, 2019
5 checks passed
5 checks passed
denoland.deno_std Build #20190912.2 succeeded
Details
denoland.deno_std (Linux) Linux succeeded
Details
denoland.deno_std (Mac) Mac succeeded
Details
denoland.deno_std (Windows) Windows succeeded
Details
license/cla Contributor License Agreement is signed.
Details
ry added a commit to ry/deno that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.