Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [ws] wss support with dialTLS #615

Merged
merged 2 commits into from Sep 28, 2019

Conversation

@keroxp
Copy link
Contributor

commented Sep 28, 2019

  • feat: wss support with dialTLS
  • fixed: Default port check by url.protocol was not working
keroxp added 2 commits Sep 28, 2019
@ry
ry approved these changes Sep 28, 2019
Copy link
Contributor

left a comment

LGTM !

conn = await Deno.dial({ hostname, port });
} else if (url.protocol === "https:" || url.protocol === "wss:") {
const port = parseInt(url.port || "443");
conn = await Deno.dialTLS({ hostname, port });

This comment has been minimized.

Copy link
@ry

ry Sep 28, 2019

Contributor

Probably we should make it so dialTLS also accepts port as a string...

@ry ry merged commit cac2d5e into denoland:master Sep 28, 2019
5 checks passed
5 checks passed
denoland.deno_std Build #20190928.2 succeeded
Details
denoland.deno_std (Linux) Linux succeeded
Details
denoland.deno_std (Mac) Mac succeeded
Details
denoland.deno_std (Windows) Windows succeeded
Details
license/cla Contributor License Agreement is signed.
Details
ry added a commit to ry/deno that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.