Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): add url and crypto native module polyfills #729

Merged
merged 1 commit into from Feb 16, 2021

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 15, 2021

This PR adds url and crypto native module polyfills, and adds testing for checking native module polyfills. (url and crypto already exist but not polyfilled for require)

This PR also updates node/README.md to reflect the current state of std/node.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k
Copy link
Member Author

kt3k commented Feb 16, 2021

@bartlomieju Thank you for your review!

@kt3k kt3k merged commit 63b2a8d into denoland:main Feb 16, 2021
@kt3k kt3k deleted the feat/add-crypto-and-url branch February 16, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants