Skip to content

Conversation

@achedges
Copy link
Contributor

Unwinding nested ternary operator to improve readability. Increasing test line coverage to 100%.

@achedges achedges requested a review from kt3k as a code owner November 27, 2025 19:04
@github-actions github-actions bot added the http label Nov 27, 2025
@CLAassistant
Copy link

CLAassistant commented Nov 27, 2025

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.11%. Comparing base (7e8c8d2) to head (4d18227).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6885   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files         581      581           
  Lines       42704    42707    +3     
  Branches     6793     6796    +3     
=======================================
+ Hits        40190    40194    +4     
  Misses       2463     2463           
+ Partials       51       50    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k changed the title test(http): reached full line coverage, unwind ternary to improve reability refactor(http): reached full line coverage, unwind ternary to improve reability Nov 28, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nicer to me. Thanks!

@kt3k kt3k merged commit 1e1c7a7 into denoland:main Nov 28, 2025
20 checks passed
@achedges achedges deleted the http-etag-tests branch November 28, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants