Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge axetroy's extension #125

Merged
merged 3 commits into from Aug 10, 2020

Conversation

@bartlomieju
Copy link
Contributor

bartlomieju commented Aug 7, 2020

CC @ry @axetroy @justjavac

@axetroy
Copy link
Contributor

axetroy commented Aug 7, 2020

It is difficult to review with a lot of files.

But I give some points that need to be changed:

  1. README.md
  • badge
  • link
  • image
  • license
  1. package.json
  • package name
  • publisher name
  • version

One more thing

The current CI is passed, but after the merger, the CI must fail.

because the coverage of the test case will be sent to Coveralls, but there should be no token set currently

@ry
ry approved these changes Aug 10, 2020
Copy link
Member

ry left a comment

LGTM - I haven't reviewed the code but I think we ought to just move forward based on what I hear...

Copy link
Contributor

justjavac left a comment

LGTM - just merge it

@justjavac
Copy link
Contributor

justjavac commented Aug 10, 2020

Two months ago, it was my biggest regret that @axetroy's code was not merged. Thank you @bartlomieju

bartlomieju added 2 commits Aug 10, 2020
@bartlomieju
Copy link
Contributor Author

bartlomieju commented Aug 10, 2020

I changed the badges; removed coveralls report for now; removed automatic release process for now (need to setup and test tokens from Azure)

@bartlomieju bartlomieju merged commit bacff2a into denoland:master Aug 10, 2020
3 checks passed
3 checks passed
test in ubuntu-latest
Details
test in macOS-latest
Details
test in windows-latest
Details
@bartlomieju bartlomieju deleted the bartlomieju:merge_axetroy_extension branch Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.