-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: getRelativeRepoPath for the case of vault-inside-repo #722
Conversation
d8a2a78
to
1c6f547
Compare
Hey, thanks for this pr and your contribution! This was a great start, but I changed it so that the basePath setting is not needed to point to the repo root, but can be a subdirectory. Additionally, I needed to align the |
Hi. Thanks for the fixing. It works as I supposed. |
Okay great. But the submodule issue was there before this pr and persisted after your version of this pr as well, right? |
Yes. |
thanks folks! |
This fixes #660.
Currently,
getRelativeRepoPath
considers only the case of git repository is located inside the vault.If the vault is inside a subdirectory of git repository (this is a common case when you are using a self-host publishing system like Quartz), line authoring feature won't work.
This code resolves the relative path between git repo and vault using
path
library.