Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a fixer for r based on the styler package #2401
Merged
Conversation
autoload/ale/fixers/styler.vim
Outdated
| @@ -0,0 +1,16 @@ | |||
| " Author: tvatter <thibault.vatter@gmail.com> | |||
| " Description: Fixing R files with syler. | |||
lorenzwalthert
Apr 10, 2019
There is a typo in syler.
There is a typo in syler.
tvatter
Apr 10, 2019
Author
Contributor
Just corrected
Just corrected
|
Looks good to me. Add it to the list of supported tools in the Markdown and Vim help files, and add a test for the fixer here. See |
|
|
Have a look at existing tests for fixers, and the documentation which shows how to write a test. |
|
|
The tests dot not pass, but it's not due to my stuff right? |
| \ 'styler': { | ||
| \ 'function': 'ale#fixers#styler#Fix', | ||
| \ 'suggested_filetypes': ['r'], | ||
| \ 'description': 'Fix R files with styler.', | ||
| \ 'latexindent': { |
lorenzwalthert
Apr 22, 2019
Well I think you might be missing a } here?
Well I think you might be missing a } here?
tvatter
Apr 22, 2019
Author
Contributor
Right, thanks!
Right, thanks!
lorenzwalthert
Apr 22, 2019
Now tests pass, hooray 😄 .
Now tests pass, hooray
tvatter
Apr 22, 2019
Author
Contributor
Indeed :)
Indeed :)
|
Cheers! |
|
Thanks @tvatter. Do you want to tweet about it? I'll retweet. |
|
Sure, I just did :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #1483.
This is a simple fixer for R based on the styler package. It should solve #1483 and has also been requested elsewhere.