Add a fixer for r based on the styler package#2401
Merged
w0rp merged 8 commits intodense-analysis:masterfrom Apr 23, 2019
tvatter:fixers-styler
Merged
Add a fixer for r based on the styler package#2401w0rp merged 8 commits intodense-analysis:masterfrom tvatter:fixers-styler
w0rp merged 8 commits intodense-analysis:masterfrom
tvatter:fixers-styler
Conversation
autoload/ale/fixers/styler.vim
Outdated
| @@ -0,0 +1,16 @@ | |||
| " Author: tvatter <thibault.vatter@gmail.com> | |||
| " Description: Fixing R files with syler. | |||
w0rp
requested changes
Apr 10, 2019
Member
w0rp
left a comment
There was a problem hiding this comment.
Looks good to me. Add it to the list of supported tools in the Markdown and Vim help files, and add a test for the fixer here. See :help ale-tests.
Contributor
Author
|
Member
|
Have a look at existing tests for fixers, and the documentation which shows how to write a test. |
Contributor
Author
|
Contributor
Author
|
The tests dot not pass, but it's not due to my stuff right? |
| \ 'function': 'ale#fixers#styler#Fix', | ||
| \ 'suggested_filetypes': ['r'], | ||
| \ 'description': 'Fix R files with styler.', | ||
| \ 'latexindent': { |
There was a problem hiding this comment.
Well I think you might be missing a } here?
w0rp
approved these changes
Apr 23, 2019
Member
|
Cheers! 🍻 |
|
Thanks @tvatter. Do you want to tweet about it? I'll retweet. |
Contributor
Author
|
Sure, I just did :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1483.
This is a simple fixer for R based on the styler package. It should solve #1483 and has also been requested elsewhere.